Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rental-agreement-application): Property condition subsection #16361

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

hebaulf
Copy link

@hebaulf hebaulf commented Oct 10, 2024

Property condition subsection

Attach a link to issue if relevant

What

  • Update "property condition" subsection
  • Add fields needed and format where needed

Why

Applicant should be able to add information about the property condition and who does the inspection.

Screenshots / Gifs

Screenshot 2024-10-10 at 15 45 02

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@hebaulf hebaulf requested a review from a team as a code owner October 10, 2024 15:45
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.86%. Comparing base (552aafd) to head (be126f7).
Report is 1 commits behind head on rental-agreement-application.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           rental-agreement-application   #16361      +/-   ##
================================================================
+ Coverage                         36.76%   36.86%   +0.10%     
================================================================
  Files                              6805     6804       -1     
  Lines                            140946   140691     -255     
  Branches                          40191    40067     -124     
================================================================
+ Hits                              51819    51871      +52     
+ Misses                            89127    88820     -307     
Flag Coverage Δ
air-discount-scheme-backend 54.06% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.37% <ø> (ø)
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 36.93% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.77% <ø> (+0.28%) ⬆️
api-domains-communications 39.91% <ø> (ø)
api-domains-criminal-record 48.00% <ø> (ø)
api-domains-driving-license 44.40% <ø> (ø)
api-domains-education 31.51% <ø> (ø)
api-domains-health-insurance 34.88% <ø> (+0.10%) ⬆️
api-domains-mortgage-certificate 35.70% <ø> (+0.75%) ⬆️
api-domains-payment-schedule 41.16% <ø> (ø)
application-api-files 58.10% <ø> (ø)
application-core 71.63% <ø> (-0.21%) ⬇️
application-system-api 41.67% <ø> (+0.21%) ⬆️
application-template-api-modules 24.31% <ø> (-3.69%) ⬇️
application-templates-accident-notification 29.44% <ø> (+0.15%) ⬆️
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.63% <ø> (+0.28%) ⬆️
application-templates-driving-license 18.40% <ø> (+0.11%) ⬆️
application-templates-estate 12.32% <ø> (+0.01%) ⬆️
application-templates-example-payment 25.41% <ø> (+0.27%) ⬆️
application-templates-financial-aid 14.34% <ø> (+0.06%) ⬆️
application-templates-general-petition 23.68% <ø> (+0.24%) ⬆️
application-templates-health-insurance 26.62% <ø> (+0.21%) ⬆️
application-templates-inheritance-report 6.45% <ø> (+0.02%) ⬆️
application-templates-marriage-conditions 15.23% <ø> (+0.14%) ⬆️
application-templates-mortgage-certificate 44.08% <ø> (+0.21%) ⬆️
application-types 6.65% <ø> (ø)
application-ui-components 1.28% <ø> (ø)
application-ui-shell 21.27% <ø> (-0.01%) ⬇️
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 29.84% <ø> (ø)
auth-react 22.77% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
clients-driving-license 40.67% <ø> (ø)
clients-driving-license-book 43.80% <ø> (ø)
clients-financial-statements-inao 49.32% <ø> (ø)
clients-license-client 1.83% <ø> (ø)
clients-middlewares 72.79% <ø> (-0.34%) ⬇️
clients-regulations 42.80% <ø> (ø)
clients-rsk-company-registry 29.76% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.52% <ø> (+0.07%) ⬆️
clients-zendesk 54.61% <ø> (ø)
cms 0.43% <ø> (ø)
cms-translations 39.04% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.16% <ø> (ø)
contentful-apps 5.57% <ø> (ø)
dokobit-signing 63.38% <ø> (ø)
download-service 44.02% <ø> (-0.20%) ⬇️
email-service 61.13% <ø> (ø)
feature-flags 91.11% <ø> (ø)
file-storage 53.71% <ø> (ø)
financial-aid-backend 56.40% <ø> (ø)
financial-aid-shared 19.03% <ø> (ø)
icelandic-names-registry-backend 53.97% <ø> (ø)
island-ui-core 28.39% <ø> (ø)
judicial-system-api 18.29% <ø> (-0.11%) ⬇️
judicial-system-audit-trail 69.35% <ø> (ø)
judicial-system-backend 55.16% <ø> (-0.04%) ⬇️
judicial-system-formatters 79.90% <ø> (ø)
judicial-system-message 67.24% <ø> (ø)
judicial-system-types 47.44% <ø> (ø)
judicial-system-web 27.96% <ø> (ø)
license-api 42.54% <ø> (-0.13%) ⬇️
localization 10.15% <ø> (ø)
logging 48.43% <ø> (ø)
message-queue 68.50% <ø> (+0.78%) ⬆️
nest-audit 68.20% <ø> (ø)
nova-sms 62.74% <ø> (ø)
portals-admin-regulations-admin 1.88% <ø> (+0.02%) ⬆️
reference-backend 49.79% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 52.13% <ø> (+0.28%) ⬆️
services-auth-delegation-api 57.66% <ø> (+0.27%) ⬆️
services-auth-ids-api 51.71% <ø> (+0.26%) ⬆️
services-auth-personal-representative 45.42% <ø> (+0.29%) ⬆️
services-auth-personal-representative-public 41.53% <ø> (+0.21%) ⬆️
services-auth-public-api 49.21% <ø> (+0.29%) ⬆️
services-documents 60.58% <ø> (ø)
services-endorsements-api 55.04% <ø> (+0.85%) ⬆️
services-sessions 65.37% <ø> (ø)
services-university-gateway 48.40% <ø> (+0.11%) ⬆️
services-user-notification 47.04% <ø> (+0.02%) ⬆️
services-user-profile 62.10% <ø> (-0.08%) ⬇️
shared-components 27.65% <ø> (ø)
shared-form-fields 31.59% <ø> (ø)
shared-mocking 64.62% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 27.90% <ø> (ø)
skilavottord-ws 24.24% <ø> (ø)
testing-e2e 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 149 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552aafd...be126f7. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Oct 10, 2024

Datadog Report

All test runs 5957ad2 🔗

99 Total Test Services: 0 Failed, 97 Passed
🔻 Test Sessions change in coverage: 8 decreased, 14 increased, 178 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 81 0 29.56s N/A Link
air-discount-scheme-web 0 0 0 2 0 7.67s N/A Link
api 0 0 0 4 0 2.55s N/A Link
api-catalogue-services 0 0 0 23 0 10.86s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 20.32s N/A Link
api-domains-assets 0 0 0 3 0 12.95s N/A Link
api-domains-auth-admin 0 0 0 18 0 14.1s N/A Link
api-domains-communications 0 0 0 5 0 30.12s N/A Link
api-domains-criminal-record 0 0 0 5 0 8.79s N/A Link
api-domains-driving-license 0 0 0 23 0 30.69s N/A Link

🔻 Code Coverage Decreases vs Default Branch (8)

This report shows up to 5 code coverage decreases.

  • application-template-api-modules - jest 26.03% (-4.07%) - Details
  • license-api - jest 33.83% (-0.11%) - Details
  • judicial-system-scheduler - jest 75.33% (-0.1%) - Details
  • judicial-system-formatters - jest 88.11% (-0.06%) - Details
  • services-auth-admin-api - jest 47.52% (-0.04%) - Details

Copy link
Member

@jonnigs jonnigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks for the subSection otherwise good :)

@hebaulf hebaulf requested a review from addi October 16, 2024 09:38
@hebaulf hebaulf merged commit 97d5fc3 into rental-agreement-application Oct 16, 2024
256 of 265 checks passed
@hebaulf hebaulf deleted the feat/property-condition branch October 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants